-
Notifications
You must be signed in to change notification settings - Fork 113
Adopt multilineArraysWrapThreshold to always wrap arrays redux #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Mon, 19 Jan 2026 16:41:35 GMT legacy29 files identical
latest14 files identical
|
JSON approval analysis:Time updated: Mon, 19 Jan 2026 16:41:41 GMT latest🎯 OVERALL APPROVAL STATUS✅ AUTO-APPROVED |
| // Skip over if we have no subfeatures | ||
| if (!('features' in baseFeature)) continue; | ||
| for (const [subFeatureName] of Object.entries(baseFeature.features)) { | ||
| for (const [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky, but this one seems kinda wonky — this is just bracket notation, isn't it? Not sure there's an obvious fix if the library thinks it's an array, though, so willing to live with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't see this. Doubt there's a fix... other than making it JSON only. Equally if we wanted a new field the line change diff would be better so I don't hate it either.
laghee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment where it seems to be interpreting a property accessor as an array, but not a deal-breaker.
Asana Task/Github Issue: https://app.asana.com/0/1200890834746050/1209117386771959/f
Description
Feature change process:
Site breakage mitigation process:
Brief explanation
Note
Switches Prettier to always wrap arrays and reformats repository files accordingly, with no functional changes.
multilineArraysWrapThresholdto0in.prettierrcto always wrap arrays.automation-utils.js,index.js,util.js,eslint.config.mjs,features/*,overrides/*,tests/*,.github/scripts/json-diff-directories.js).Written by Cursor Bugbot for commit ab4a37b. This will update automatically on new commits. Configure here.