Skip to content

Conversation

@jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Dec 11, 2025

Asana Task/Github Issue: https://app.asana.com/0/1200890834746050/1209117386771959/f

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

Note

Switches Prettier to always wrap arrays and reformats repository files accordingly, with no functional changes.

  • Tooling:
    • Prettier config: set multilineArraysWrapThreshold to 0 in .prettierrc to always wrap arrays.
  • Codebase-wide reformat:
    • Reformats arrays to multiline across JS/JSON files (automation-utils.js, index.js, util.js, eslint.config.mjs, features/*, overrides/*, tests/*, .github/scripts/json-diff-directories.js).
    • No behavioral changes; updates are formatting-only.

Written by Cursor Bugbot for commit ab4a37b. This will update automatically on new commits. Configure here.

@github-actions
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Generated file outputs:

Time updated: Mon, 19 Jan 2026 16:41:35 GMT

legacy
29 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

latest
14 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

JSON approval analysis:

Time updated: Mon, 19 Jan 2026 16:41:41 GMT

latest

🎯 OVERALL APPROVAL STATUS

✅ AUTO-APPROVED

// Skip over if we have no subfeatures
if (!('features' in baseFeature)) continue;
for (const [subFeatureName] of Object.entries(baseFeature.features)) {
for (const [
Copy link
Contributor

@laghee laghee Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but this one seems kinda wonky — this is just bracket notation, isn't it? Not sure there's an obvious fix if the library thinks it's an array, though, so willing to live with it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see this. Doubt there's a fix... other than making it JSON only. Equally if we wanted a new field the line change diff would be better so I don't hate it either.

Copy link
Contributor

@laghee laghee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment where it seems to be interpreting a property accessor as an array, but not a deal-breaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants