Skip to content

Conversation

@samhouts
Copy link

@samhouts samhouts commented Jan 8, 2026

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1212550787228109?focus=true

Description

This adds a feature flag to enable or disable the session monitoring for New Tab Page/Home Button Entry and Exit points.

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Note

Introduces session monitoring control for New Tab Page/Home flows via a new feature flag in overrides/windows-override.json.

  • Adds newTabPageSessionMonitoring with sub-features: entryPoints set to enabled, exitPoints set to internal

Written by Cursor Bugbot for commit 14da9aa. This will update automatically on new commits. Configure here.

github-actions bot pushed a commit that referenced this pull request Jan 8, 2026
@samhouts samhouts marked this pull request as ready for review January 8, 2026 23:27
@samhouts samhouts requested a review from daxtheduck as a code owner January 8, 2026 23:27
Copilot AI review requested due to automatic review settings January 8, 2026 23:27
@samhouts samhouts requested review from a team as code owners January 8, 2026 23:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new feature flag newTabPageSessionMonitoring to the Windows override configuration file. The feature flag controls session monitoring for New Tab Page and Home Button entry and exit points, and is currently disabled by default.

Key Changes:

  • Added newTabPageSessionMonitoring feature flag with nested configuration for entryPoints and exitPoints
  • All monitoring states are set to disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions bot pushed a commit that referenced this pull request Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Generated file outputs:

Time updated: Fri, 16 Jan 2026 21:54:21 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -110423,8 +110423,20 @@
                 "videoPlayback": "enabled",
                 "urlChanged": "enabled"
             }
         },
+        "newTabPageSessionMonitoring": {
+            "state": "enabled",
+            "features": {
+                "entryPoints": {
+                    "state": "enabled"
+                },
+                "exitPoints": {
+                    "state": "disabled"
+                }
+            },
+            "exceptions": []
+        },
         "windowsWebviewFailures_DDGWV": {
             "state": "enabled",
             "exceptions": [],
             "features": {
v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -109465,8 +109465,19 @@
                 "videoPlayback": "enabled",
                 "urlChanged": "enabled"
             }
         },
+        "newTabPageSessionMonitoring": {
+            "state": "enabled",
+            "features": {
+                "entryPoints": {
+                    "state": "enabled"
+                },
+                "exitPoints": {
+                    "state": "internal"
+                }
+            }
+        },
         "windowsWebviewFailures_DDGWV": {
             "state": "enabled",
             "exceptions": [],
             "features": {
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json

⚠️ File is identical

v5/windows-config.json
--- v5/windows-config.json
+++ v5/windows-config.json
@@ -109465,8 +109465,19 @@
                 "videoPlayback": "enabled",
                 "urlChanged": "enabled"
             }
         },
+        "newTabPageSessionMonitoring": {
+            "state": "enabled",
+            "features": {
+                "entryPoints": {
+                    "state": "enabled"
+                },
+                "exitPoints": {
+                    "state": "internal"
+                }
+            }
+        },
         "windowsWebviewFailures_DDGWV": {
             "state": "enabled",
             "exceptions": [],
             "features": {

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

JSON approval analysis:

Time updated: Fri, 16 Jan 2026 21:54:26 GMT

legacy

❌ Manual Review Required

  • v3/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/newTabPageSessionMonitoring (add)
  • v4/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/newTabPageSessionMonitoring (add)
latest

❌ Manual Review Required

  • v5/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/newTabPageSessionMonitoring (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant