Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 16, 2026

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1212836962171230?focus=true

Description

Add FF for VPN activation reminder

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

Note

Introduces a new Privacy Pro feature flag vpnReminderNotification in overrides/android-override.json.

  • Adds vpnReminderNotification (state: enabled) under privacyPro.features, targeted to localeLanguage: "en"

Written by Cursor Bugbot for commit 729bfc6. This will update automatically on new commits. Configure here.

@nalcalag nalcalag requested review from a team and daxtheduck as code owners January 16, 2026 19:21
github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
@github-actions
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Generated file outputs:

Time updated: Fri, 16 Jan 2026 19:26:57 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/android-config.json
  • v4/android-config.json
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -104751,8 +104751,16 @@
                 },
                 "supportsSwitchSubscription": {
                     "state": "enabled",
                     "minSupportedVersion": 52591000
+                },
+                "vpnReminderNotification": {
+                    "state": "enabled",
+                    "targets": [
+                        {
+                            "localeLanguage": "en"
+                        }
+                    ]
                 }
             }
         },
         "privacyProtectionsPopup": {
latest
v5/android-config.json
--- v5/android-config.json
+++ v5/android-config.json
@@ -104751,8 +104751,16 @@
                 },
                 "supportsSwitchSubscription": {
                     "state": "enabled",
                     "minSupportedVersion": 52591000
+                },
+                "vpnReminderNotification": {
+                    "state": "enabled",
+                    "targets": [
+                        {
+                            "localeLanguage": "en"
+                        }
+                    ]
                 }
             }
         },
         "privacyProtectionsPopup": {
13 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

JSON approval analysis:

Time updated: Fri, 16 Jan 2026 19:27:04 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/vpnReminderNotification (add)
  • v4/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/vpnReminderNotification (add)
latest

❌ Manual Review Required

  • v5/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/vpnReminderNotification (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant