Enable max-height for trackers and non-trackers on macOS and Windows#339
Draft
Enable max-height for trackers and non-trackers on macOS and Windows#339
Conversation
✅ Deploy Preview for ddgdash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
NPM npm i github:duckduckgo/privacy-dashboard#66750278a8468d0fd3e6828670a241e78ad83258Git submodule: git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227Swift .package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "66750278a8468d0fd3e6828670a241e78ad83258"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/1204912272578138/1206836677703864
Description:
The breakage form has a height cap applied to the setSize method on macOS and Windows to prevent the popover from growing to a ridiculous height.
This change applies the same height cap to the Trackers and Non-Trackers subviews of the dashboard
Steps to test this PR:
This needs to be tested natively. Test build to come soon...