Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate click handling where both the internal help page and public help page was opened
Note
Medium Risk
Changes link click behavior inside the Zendesk iframe by intercepting clicks and forcing
window.open, which could affect navigation, popup blocking, or event handling if the widget behavior changes.Overview
Rewrites Zendesk article anchor clicks to avoid duplicate navigation after updating their
href.When an article link is remapped, the code now adds a one-time capture-phase
clickhandler that prevents Zendesk’s default/internal handlers and explicitly opens the rewritten URL in a new tab (noopener,noreferrer).Reviewed by Cursor Bugbot for commit 9c7b527. Bugbot is set up for automated code reviews on this repo. Configure here.