Prevent multi <style> generation - #337
Open
andreas-trad wants to merge 1 commit into
Open
Conversation
If the autogenerate_stylesheet option is set to true then the library is adding multiple times the same style on the head of the document (see the source of the http://gridster.net/demos/adding-widgets-dynamically.html demo in order to observe this). With this correction the gridster style element is only inserted once on the style.
|
Looks great I merged it into my fork dsmorse/gridster.js |
|
Just as an FYI, this causes a problem is you use multiple namespaces... I'm working a fix for my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the autogenerate_stylesheet option is set to true then the library is adding multiple times the same style on the head of the document (see the source of the http://gridster.net/demos/adding-widgets-dynamically.html demo in order to observe this). With this correction the gridster style element is only inserted once on the head