Lucijs backend home page #484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaric99
requested changes
Jan 27, 2025
| import RecommendationsButton from '../../../../components/RecommendationsButton'; | ||
| import { CompanyPublicDto } from '@ddays-app/types'; | ||
|
|
||
| async function fetchTopRatedCompanies(): Promise<CompanyPublicDto[] | undefined> { |
There was a problem hiding this comment.
Nebi fetchala podatke direkt u komponentama, mozes izvuc ove stvari u custom hookove po potrebi ako su podaci potrebni na vise mista napravit provider
lovretomic
requested changes
Mar 1, 2025
There was a problem hiding this comment.
merge markeri ostali? nesto se skrsilo kod konflikata
ToniGrbic
requested changes
Apr 14, 2025
Comment on lines
103
to
110
| useEffect(() => { | ||
| const loadEventsWithSpeakers = async () => { | ||
| const fetchedCompanies = await fetchEvents(); | ||
| if (fetchedCompanies) setEvents(fetchedCompanies); | ||
| }; | ||
|
|
||
| loadEventsWithSpeakers(); | ||
| }, []); |
There was a problem hiding this comment.
refactora bi ovu funkciju za fetch events i useEffect u hook sa useQuery kad smo vec za sve ostale.
ToniGrbic
reviewed
Apr 30, 2025
Comment on lines
76
to
78
| console.log(displayedEvents) | ||
| console.log("live:", liveEvents) | ||
| console.log("next:",nextEvents) |
ToniGrbic
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samo san fatchala sve eventove i ovih 5 najbolje ocijenjenih kompanija, testirala san lokalno i sve radi