remove next_update col and refresh all balances #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ready-for-review
|
not urgent, feel free to batch in with other merges to daily |
looks like downstream failure? |
jeff-dude
added
WIP
|
is this still valid? |
github-actions
bot
added
ready-for-review
|
should be good to go @jeff-dude |
jeff-dude
approved these changes
Mar 25, 2025
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
The
next_updatecolumn is only used within the macro, and should not be relied upon for further downstream models since it's not updated retroactively for records outside the incremental window.There are also some minor data gaps in some balances models which will benefit from a proper full refresh.
quick links for more information: