WIP: Adds a spell for NEAR blockchain ft_transfer_calls #7900
+180
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
danzipie
force-pushed
the
ft_transfer_call
branch
6 times, most recently
from
8f1fb0e to
59733b9
Compare
danzipie
changed the title
github-actions
bot
added
ready-for-review
danzipie
force-pushed
the
ft_transfer_call
branch
from
59733b9 to
2e38584
Compare
jeff-dude
requested changes
Mar 24, 2025
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/near/ft_transfer_calls/schema.yml
Outdated
Show resolved
Hide resolved
jeff-dude
added
in review
danzipie
force-pushed
the
ft_transfer_call
branch
6 times, most recently
from
3357657 to
aa5eb71
Compare
jeff-dude
requested changes
Mar 25, 2025
dbt_subprojects/daily_spellbook/models/near/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
danzipie
force-pushed
the
ft_transfer_call
branch
2 times, most recently
from
943a6ae to
532d448
Compare
|
once you apply all changes and CI workflows complete, plz do test the data output to ensure you are happy with results. you can go into logs here (when complete) |
jeff-dude
reviewed
Mar 25, 2025
dbt_subprojects/daily_spellbook/models/near/near_ft_transfer_calls.sql
Outdated
Show resolved
Hide resolved
danzipie
force-pushed
the
ft_transfer_call
branch
from
532d448 to
8ece5ba
Compare
danzipie
force-pushed
the
ft_transfer_call
branch
6 times, most recently
from
b348bde to
4f8d7a3
Compare
Adds a spell for NEAR blockchain (resolution of ft_transfer_calls). ft_transfer_call is one of the two ways to send fungible tokens according to the NEP-141 standard. Until now only the other method is covered (ft_transfer through the ft_transfers table). This contribution adds coverage for the ft_transfer_call, which according to the standard: transfer tokens and call a method on a receiver contract. A successful workflow will end in a success execution outcome to the callback on the same contract at the method ft_resolve_transfer. You can think of this as being similar to attaching native NEAR tokens to a function call. It allows you to attach any Fungible Token in a call to a receiver contract.
danzipie
force-pushed
the
ft_transfer_call
branch
from
4f8d7a3 to
2be5d13
Compare
|
run times look much better & code looking good 🔥 did you get a chance to query |
danzipie
changed the title
|
Hi @jeff-dude that you very much for your reviews! After doing several manual tests, I realised that I had initially misunderstood the problem. The example of undetected transfer: https://nearblocks.io/txns/6a2Pddo4MQgePhj3NLVqhh6HAECrP6xzatp78wKJRoeV# I will close this PR and work on the actual problem. |
|
all good, hopefully the process still helped you understand spellbook further 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spell for NEAR blockchain ft_transfer_calls.
ft_transfer_callis one of the two ways to send fungible tokens according to the NEP-141 standard. Until now only the other method is covered (ft_transferthrough theft_transferstable).This contribution adds coverage for the
ft_transfer_call, which according to the standard:source: https://github.com/near/NEPs/blob/master/neps/nep-0141.md
TLDR: Without this spell, many Fungible Token transfers are simply not parsed, because they don't appear in the
ft_transfers.