Skip to content

Add Axie Marketplace to nft trades #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

peterrliem
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft April 3, 2025 11:02
@github-actions github-actions bot added the WIP work in progress label Apr 3, 2025
@github-actions github-actions bot added the dbt: nft covers the NFT dbt subproject label Apr 3, 2025
@peterrliem
Copy link
Contributor Author

peterrliem commented Apr 3, 2025

Ran this and got 0 results of duplicates:

SELECT
  block_number,
  tx_hash,
  sub_tx_trade_id,
  COUNT(*) AS records
FROM hive.test_schema.git_dunesql_bc2db89_dbt_utils_unique_combination_of_columns_axie_marketplace_ronin_base_trades_block_number__tx_hash__sub_tx_tra
GROUP BY 1, 2, 3
HAVING COUNT(*) > 1
ORDER BY records DESC
LIMIT 10000

@0xRobin can you help me check why my tests failed?

@peterrliem peterrliem marked this pull request as ready for review April 3, 2025 19:20
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Apr 3, 2025
@jeff-dude
Copy link
Member

Ran this and got 0 results of duplicates:

SELECT
  block_number,
  tx_hash,
  sub_tx_trade_id,
  COUNT(*) AS records
FROM hive.test_schema.git_dunesql_bc2db89_dbt_utils_unique_combination_of_columns_axie_marketplace_ronin_base_trades_block_number__tx_hash__sub_tx_tra
GROUP BY 1, 2, 3
HAVING COUNT(*) > 1
ORDER BY records DESC
LIMIT 10000

@0xRobin can you help me check why my tests failed?

we shouldn't just remove the test from schema file. we should find the issue. typically if you are seeing an error on unique keys test, it's due to one of the three columns used allowing for nulls. dbt doesn't handle nulls in keys well. can you ensure none of the three have any nulls?

rather than query the output from CI logs, try running dbt compile and grabbing raw sql and using that for your source query to run tests against

@jeff-dude
Copy link
Member

while this investigation happens, i will move back to draft mode

@jeff-dude jeff-dude marked this pull request as draft April 7, 2025 15:30
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: nft covers the NFT dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants