Skip to content

Conversation

@DavidbigC
Copy link

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft April 10, 2025 21:10
@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Apr 10, 2025
@DavidbigC
Copy link
Author

I made the changes because Meteora doesnt really follow the kind of inner_instruction_index + 1 + 2 format.
for most trades, it does, until it does not.
e.g.,
51WeczDXGARQdSeRiR4g5iNSw95iGZvGcrccbsjW3jj1GY2SSP4pUSh37Eu2UbToSt8hBrRac1fRvEaZoAgVjRfU
the first transfer send 0.00473 to the same account, which was logged as the sold value in the original table

I am joining tables by to_owner & from_owner.
since its a dex, they will always point to the lp - lbpair

@jeff-dude jeff-dude requested a review from 0xBoxer April 11, 2025 03:11
@jeff-dude jeff-dude marked this pull request as ready for review April 11, 2025 03:12
Copilot AI review requested due to automatic review settings April 11, 2025 03:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • dbt_subprojects/solana/models/_sector/dex/meteora/meteora_v2_solana_base_trades.sql: Language not supported

@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Apr 11, 2025
@jeff-dude jeff-dude marked this pull request as draft May 1, 2025 11:16
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels May 1, 2025
@0xBoxer
Copy link
Collaborator

0xBoxer commented May 1, 2025

closing this in favour of #8094 , which was easier to work on for me.

thanks for the work @DavidbigC, could verify and fix the issue in the #8094 branch by adding an additional join condition for the transfers join. We are still finishing up some work on tokens.transfers so this will take another couple days to be merged into prod

@0xBoxer 0xBoxer closed this May 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: solana covers the Solana dbt subproject WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants