Skip to content

CUR2-151 Balances daily agg: Use correct unique_key and partition by day #8054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

aalan3
Copy link
Contributor

@aalan3 aalan3 commented Apr 21, 2025

We are using the wrong unique_key which causes there to be multiple values for a day. This is not the case for ethereum which doesn't use block_number in the unique key.

@aalan3 aalan3 requested review from jeff-dude and Copilot April 21, 2025 18:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (8)
  • dbt_subprojects/tokens/models/transfers_and_balances/arbitrum/tokens_arbitrum_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/avalanche_c/tokens_avalanche_c_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/base/tokens_base_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/kaia/tokens_kaia_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/linea/tokens_linea_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/optimism/tokens_optimism_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/polygon/tokens_polygon_balances_daily_agg_base.sql: Language not supported
  • dbt_subprojects/tokens/models/transfers_and_balances/worldchain/tokens_worldchain_balances_daily_agg_base.sql: Language not supported

@github-actions github-actions bot marked this pull request as draft April 21, 2025 18:53
@github-actions github-actions bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Apr 21, 2025
@aalan3 aalan3 marked this pull request as ready for review April 21, 2025 18:53
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Apr 21, 2025
@jeff-dude jeff-dude self-assigned this Apr 21, 2025
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Apr 21, 2025
@jeff-dude jeff-dude changed the title Balances daily agg: Use correct unique_key and partition by day CUR2-151 Balances daily agg: Use correct unique_key and partition by day Apr 22, 2025
@jeff-dude jeff-dude merged commit ca1bb3d into main Apr 22, 2025
4 checks passed
@jeff-dude jeff-dude deleted the balances-daily-agg-fix branch April 22, 2025 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants