"static" linux glibc builder #1448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Mar 19, 2025
| @@ -0,0 +1,236 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Can we try to no duplicate the script but just add a switch on the existing one?
There was a problem hiding this comment.
That was what I thought of doing first, but it quickly became messy. I'll get it working with a docker container first and then see to combine the two scripts.
|
I'm not terribly familiar with docker so you'll likely have to bring it up to standard once I've got it working. |
|
Did you see #1438? It contains a working |
|
I hadn't seen that, I'll work off of that branch instead and close this once I've merged my changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress