Skip to content

Conversation

@abdounikarim
Copy link
Contributor

Added instructions for installing Symfony 6.4 and configuring FrankenPHP.

Added instructions for installing Symfony 6.4 and configuring FrankenPHP.
Copy link
Contributor

@7-zete-7 7-zete-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is useful information for documentation.

I have a couple of comments.

>
> If you install a Symfony 6.4 version, you also need to do these steps:
>
> ```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is done in the other blocks of code

Suggested change
> ```bash
> ```console

Comment on lines +38 to +48
```Caddyfile
frankenphp {
{$FRANKENPHP_CONFIG}
worker {
file ./public/index.php
env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime
{$FRANKENPHP_WORKER_CONFIG}
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this block of code should also be wrapped in a note. WDYT?

Comment on lines +39 to +46
frankenphp {
{$FRANKENPHP_CONFIG}
worker {
file ./public/index.php
env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime
{$FRANKENPHP_WORKER_CONFIG}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs instead of spaces, as is done in Caddyfile

Suggested change
frankenphp {
{$FRANKENPHP_CONFIG}
worker {
file ./public/index.php
env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime
{$FRANKENPHP_WORKER_CONFIG}
}
frankenphp {
{$FRANKENPHP_CONFIG}
worker {
file ./public/index.php
env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime
{$FRANKENPHP_WORKER_CONFIG}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants