-
-
Notifications
You must be signed in to change notification settings - Fork 874
Update options.md with Symfony 6.4 installation steps #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
629cdad to
ca982f6
Compare
Added instructions for installing Symfony 6.4 and configuring FrankenPHP.
ca982f6 to
4c44260
Compare
7-zete-7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is useful information for documentation.
I have a couple of comments.
| > | ||
| > If you install a Symfony 6.4 version, you also need to do these steps: | ||
| > | ||
| > ```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is done in the other blocks of code
| > ```bash | |
| > ```console |
| ```Caddyfile | ||
| frankenphp { | ||
| {$FRANKENPHP_CONFIG} | ||
| worker { | ||
| file ./public/index.php | ||
| env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime | ||
| {$FRANKENPHP_WORKER_CONFIG} | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this block of code should also be wrapped in a note. WDYT?
| frankenphp { | ||
| {$FRANKENPHP_CONFIG} | ||
| worker { | ||
| file ./public/index.php | ||
| env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime | ||
| {$FRANKENPHP_WORKER_CONFIG} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs instead of spaces, as is done in Caddyfile
| frankenphp { | |
| {$FRANKENPHP_CONFIG} | |
| worker { | |
| file ./public/index.php | |
| env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime | |
| {$FRANKENPHP_WORKER_CONFIG} | |
| } | |
| frankenphp { | |
| {$FRANKENPHP_CONFIG} | |
| worker { | |
| file ./public/index.php | |
| env APP_RUNTIME Runtime\FrankenPhpSymfony\Runtime | |
| {$FRANKENPHP_WORKER_CONFIG} | |
| } |
Added instructions for installing Symfony 6.4 and configuring FrankenPHP.