Skip to content

fix: remove double "Icon" suffix for Circle, Path, and Infinity components #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathankim0 wants to merge 2 commits into from
Closed

fix: remove double "Icon" suffix for Circle, Path, and Infinity components #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d26674
fix: remove double "Icon" suffix for reserved component names
nathankim0 Sep 26, 2025
9743ae5
fix: apply maintainer's suggested fix for double Icon suffix
nathankim0 Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions generator/generate-svg.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const generateIconsDefs = async (icon, weight) => {
).replace(RegExp(`${Case.capital(weight)}$`), '');

const tsCode = await transform(svgCode, options, {
componentName: componentNameMap[componentName] || componentName,
componentName,
});

return [...tsCode.matchAll(/<Path.*? \/>/g)]
Expand Down Expand Up @@ -90,6 +90,7 @@ const getIconList = () => {
'swap',
'list',
'test-tube',
'circle',
'',
].includes(file)
);
Expand Down Expand Up @@ -139,8 +140,6 @@ ${Object.entries(defs)

const generateMainIconFile = (icon) => {
const component = Case.pascal(icon);
// const componentFileName = fileNameMap[component] || component;
const componentName = componentNameMap[component] || component;
const componentCode = `import { type Icon, type IconProps } from 'phosphor-react-native'

import IconBase from "../lib/icon-base";
Expand All @@ -150,9 +149,9 @@ const I: Icon = ({...props }: IconProps) => (
<IconBase {...props} weights={weights} name="${icon}" />
)

/** @deprecated Use ${componentName}Icon */
export const ${componentName} = I
export { I as ${componentName}Icon }`;
/** @deprecated Use ${component}Icon */
export const ${componentNameMap[component] || component} = I
export { I as ${component}Icon }`;

const filePath = path.join(__dirname, '../src/icons', `${component}.tsx`);

Expand Down