Add appendToUserAgent() method to Client class#53
Merged
jeffreyparker merged 1 commit intoJul 20, 2026
Conversation
Allow callers to append custom identifiers to the User-Agent header, matching the pattern established in duo_universal_php. The extension is trimmed before storage and appended space-separated after the existing UA string. Subsequent calls overwrite (last value wins). No-op when the extension is empty or whitespace-only.
jeffreyparker
marked this pull request as ready for review
July 15, 2026 19:17
AaronAtDuo
approved these changes
Jul 20, 2026
jeffreyparker
deleted the
jeffrpar/append-to-user-agent/append-to-user-agent
branch
July 20, 2026 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendToUserAgent(string $extension)toClient, allowing callers to append custom identifiers to the User-Agent header sent with API requestsreturn $this) consistent withsetRequesterOption()anddisableCaPinning()Design notes
appendToUserAgent()overwrite the previous value rather than concatenating. This keeps the UA string predictable and matches theduo_universal_phpbehavior.$user_agent_extensionisprivaterather thanpublicto encourage use of the setter method.Test plan