bucket: ensure Bucket::exists() honours 'dangereous' config #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fails on connections that have invalid SSL certificates. Other operations on the bucket succeed.
The existing
exists()
implementation creates adummy_bucket
and calls a static method to lookup the buckets and find ours. In doing so it discards most of the configuration in order to""
null out the bucket name.I've forced the issue by duplicating the
dummy_handle
viaclone()
. There's probably a smarter way to do this though.If the
name = ""
part isn't needed thenclone()
could be skipped altogether.This change is