-
Notifications
You must be signed in to change notification settings - Fork 235
0.37.1 #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ranges are closed, so start <= end is correct. This allows single-byte reads where start == end, which was previously rejected by the assertion. Added tests for single-byte range reads. Closes #434
Remove incorrect removal of x-amz-content-sha256 header which caused signature validation to fail. Co-authored-by: ZzIsGod1019 <[email protected]> Closes #435
|
Caution Review failedThe pull request is closed. WalkthroughThis PR bumps versions across three crates (aws-creds 0.39.0→0.39.1, aws-region 0.28.0→0.28.1, s3 0.37.0→0.37.1) and adjusts S3 range read validation to permit single-byte reads. It also adds lifecycle configuration tests, updates serde trait derivations, and modifies header handling in the PutBucketLifecycle request path. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Brownian Motion (Brass)Recommendation: Proceed Summary: PR fixes range checks and improves lifecycle handling with tests. Highlights
Unknowns
Next actions
Reflection questions
|
Brownian Motion (Brass)Recommendation: Refactor Summary: PR addresses range checks but adds complexity with minimal benefit. Highlights
Unknowns
Next actions
Reflection questions
|
This change is
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.