Persist file explorer layout and sort across tab switches - #32256
Open
PopDaph wants to merge 7 commits into
Open
Persist file explorer layout and sort across tab switches#32256PopDaph wants to merge 7 commits into
PopDaph wants to merge 7 commits into
Conversation
PopDaph
marked this pull request as ready for review
September 10, 2026 15:16
Contributor
Author
|
r? @aubin-tchoi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix: https://github.com/dust-tt/tasks/issues/8226
The file explorer kept its layout (grid/list) and sort mode in local component state, so leaving the Pod Files tab (or closing the conversation files panel) and coming back reset them to the defaults. Radix tabs unmount inactive content, so the state died on every switch.
Both are now stored through the existing
useScopedPodUiPreferenceslocalStorage hook, under a newfileExplorerscope. One preference for the whole app: the Pod Files tab and the conversation files panel share it.Tests
FileExplorer.test.tsx: preferences survive an unmount/remount when a key is set, and stay in memory when none is set.Risk
Worst case, a stored blob fails to parse and the explorer falls back to the defaults. Front-end only, safe to rollback.
Deploy Plan