Support for IHttpClientFactory and named HttpClients #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good other than it looks like some of the examples break on the new dependency, dependabot already has the fixes for that so I can see If I can get those merged in |
…mmended https://github.com/App-vNext/Polly/wiki/Avoid-compiler-gotchas-mixing-sync-and-async-execution Fixed example project dependencies
|
@Matti-Koopa Sorry it took me so long to get back to this, if you merge main into your branch I'll merge your PR in. |
|
Hello, could this pull request be merged? We need to use client certificate for request authorization and it works pretty well with this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for IHttpClientFactory and named HttpClients. If configured, the used HttpClient will instead be created from the factory.
This enables (for example) configuring a proxy or sending client certificates over SSL to authenticate on the server.
I also included a README-addition on how to include your IServiceProvider to the NLog dependency injection method.
Because this feature requires
System.Net.Http.IHttpClientFactory, which isn't part of .NET Standard 1.3 and is provided with the NuGet packageMicrosoft.Extensions.Httpwhich only support .NET Standard 2.0 and up, I added .NET Standard 2.0 target support to this project. All changes will only apply to this target.