Added structured logging support #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,10 @@ internal class GraylogMessageBuilder | |||
| private const string NLogLogLevelPropertyName = "nlog_level_name"; | |||
| private readonly JsonObject _graylogMessage = new JsonObject(); | |||
| private static readonly DateTime _epochTime = new DateTime(1970, 1, 1, 0, 0, 0, 0, DateTimeKind.Utc); | |||
| private string _structuredLoggingParameterName; | |||
|
|
|||
| public GraylogMessageBuilder(string structuredLoggingParameterName = null) | |||
There was a problem hiding this comment.
Move this to a builder method. and out of the ctor
Something like WithStructuredLoggingParameter(string parameterName) {...)
| var kvPairs = item.Split(new char[] { '=' }, 2); | ||
| if (kvPairs.Length == 2) | ||
| { | ||
| WithCustomProperty(kvPairs[0].Replace(" ", string.Empty), kvPairs[1]); |
There was a problem hiding this comment.
Do we need to do any sanitization of the property name per the gelf spec?
|
Structured logging is already supported with the current library. Example (injected Microsoft ILogger through NLog) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im new at this tell me if I've done it wrong.
Have added functionality to handle structured logging, such that the parameters you log against will appear in Greylog as parameters, not just as a conglomerated field.
To use fill in the StructuredLoggingParameterName feild in the config file and assign ${all-event-properties} to a parameter with the same name.