Extend home directory ownership test for non-standard setups #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various networked environments exist where a user's home directory is not owned by that user. With this patch Byobu checks ownership of .profile too, as a default inclusion of /etc/skel.
Owner
|
Hmm, if you want this, I think we should only be testing ownership of ~/.profile, if ~/.profile exists. Currently, byobu would run just fine, even if ~/.profile did not exist at all. But with this patch, your test would cause byobu to fail entirely if ~/.profile doesn't exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various networked environments exist where a user's home directory is not owned by that user:
With this patch Byobu checks ownership of
$HOME/.profiletoo, as a default inclusion of/etc/skel.Edit: I should also say I've been testing this patch since 2016 on a variety of Ubuntu versions (14.04 - 20.04) and it has been working fine.