Skip to content

Animation library natively added#74

Merged
duzos merged 8 commits into
duzos:masterfrom
MaketendoDev:anim-lib
May 7, 2026
Merged

Animation library natively added#74
duzos merged 8 commits into
duzos:masterfrom
MaketendoDev:anim-lib

Conversation

@MaketendoDev

@MaketendoDev MaketendoDev commented May 6, 2026

Copy link
Copy Markdown
Collaborator

About the PR

Animation library is now part of the mod instead of being seperate, this closes #64

Made it so you can easily register effect-based powers and fixes the bug where flying too fast will move the arms above the player head.

Why / Balance

It removes any confusion, lets us easily edit rendering code while testing more easier, and generally less of a pain.

Requirements

@MaketendoDev MaketendoDev requested a review from a team as a code owner May 6, 2026 22:12
@github-actions github-actions Bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label May 6, 2026
@MaketendoDev

MaketendoDev commented May 6, 2026

Copy link
Copy Markdown
Collaborator Author

oh breh I forgot to remove the old commits, eh it's ok

@MaketendoDev

Copy link
Copy Markdown
Collaborator Author
2026-05-06_23 26 45

@MaketendoDev

Copy link
Copy Markdown
Collaborator Author

closes #36

@MaketendoDev

Copy link
Copy Markdown
Collaborator Author

closes #26

@duzos duzos left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few notes from a read-through.

main one: netty/render thread race in the packet handler (see inline). also animator_version in gradle.properties is dead now that the modImplementation line is gone, can be dropped in the same change.

Comment thread src/main/java/mc/duzo/animation/network/PlayAnimationS2CPacket.java Outdated
Comment thread src/main/java/mc/duzo/timeless/suit/ironman/mk5/MarkFiveCase.java Outdated
Comment thread src/main/java/mc/duzo/timeless/suit/ironman/mk5/MarkFiveCase.java Outdated
Comment thread src/main/resources/animator.mixins.json Outdated
@duzos duzos added enhancement New feature or request and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 7, 2026
@duzos duzos self-assigned this May 7, 2026
- dispatch PlayAnimationS2CPacket.handle put through MinecraftClient.execute to avoid netty/render thread race on the tracker map
- replace MarkFiveCase ACTIVE_TRANSFORMATIONS uuid set with vanilla ItemCooldownManager (reuses existing pattern, auto-expires, syncs to client, applied symmetrically to fromCase)
- fold animator.mixins.json into timeless.mixins.json under client.animation subpackage; drop the separate config
- drop unused animator_version from gradle.properties
@duzos

duzos commented May 7, 2026

Copy link
Copy Markdown
Owner

pushed 96b8177 addressing the review.

  • PlayAnimationS2CPacket.handle now dispatches the tracker put through MinecraftClient.execute so it lands on the render thread instead of netty.
  • MarkFiveCase no longer maintains its own static uuid set. swapped for ItemCooldownManager (the pattern BaseRangItem already uses); the cooldown auto-expires after 161 ticks (~8s, matching the scheduler delay), syncs to client for free, and is applied symmetrically to toCase and fromCase so the asymmetric race is gone.
  • folded the four animation mixins into timeless.mixins.json under a client.animation subpackage. animator.mixins.json is gone, and so is its entry in fabric.mod.json.
  • dropped animator_version from gradle.properties.

./gradlew compileJava is green. left the DuzoAnimationMod/DuzoAnimationClient entrypoints as-is for now; can fold those into Timeless/TimelessClient in a follow-up if you want a single init chain.

@duzos duzos merged commit 303f628 into duzos:master May 7, 2026
1 check passed
@MaketendoDev

Copy link
Copy Markdown
Collaborator Author

fire

@MaketendoDev MaketendoDev deleted the anim-lib branch May 7, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing a mandatory mod called Animation

2 participants