Animation library natively added#74
Merged
Merged
Conversation
Collaborator
Author
|
oh breh I forgot to remove the old commits, eh it's ok |
Collaborator
Author
Collaborator
Author
|
closes #36 |
Collaborator
Author
|
closes #26 |
duzos
reviewed
May 7, 2026
duzos
left a comment
Owner
There was a problem hiding this comment.
few notes from a read-through.
main one: netty/render thread race in the packet handler (see inline). also animator_version in gradle.properties is dead now that the modImplementation line is gone, can be dropped in the same change.
- dispatch PlayAnimationS2CPacket.handle put through MinecraftClient.execute to avoid netty/render thread race on the tracker map - replace MarkFiveCase ACTIVE_TRANSFORMATIONS uuid set with vanilla ItemCooldownManager (reuses existing pattern, auto-expires, syncs to client, applied symmetrically to fromCase) - fold animator.mixins.json into timeless.mixins.json under client.animation subpackage; drop the separate config - drop unused animator_version from gradle.properties
Owner
|
pushed 96b8177 addressing the review.
|
Collaborator
Author
|
fire |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

About the PR
Animation library is now part of the mod instead of being seperate, this closes #64
Made it so you can easily register effect-based powers and fixes the bug where flying too fast will move the arms above the player head.
Why / Balance
It removes any confusion, lets us easily edit rendering code while testing more easier, and generally less of a pain.
Requirements