fix(preferences): Do not show deleted collections in sync table

[dvanoni]

Fixes #775

Summary by CodeRabbit

Bug Fixes

• Deleted collections are no longer displayed in the sync configurations table, ensuring only active collections appear in your configuration view.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change adds a filter to the buildRows function in the sync preferences table component to exclude collections marked as deleted. After loading collections, a filter condition removes entries where collection.deleted is true, ensuring only active collections are displayed in the sync preferences list. The remainder of the sorting and row generation logic remains unchanged.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The PR addresses the primary requirement from #775 by filtering deleted collections. However, it does not address renamed collections showing current names.	Verify whether renamed collection handling is in scope or if this PR intentionally addresses only deleted collections, with renamed collections handled separately.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: filtering deleted collections from the sync table display.
Out of Scope Changes check	✅ Passed	All changes are directly related to filtering deleted collections from the sync table as intended by #775.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 775-fix-deleted-collections-persist-in-prefs

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 449cb8e and 730fe6a.

📒 Files selected for processing (1)

• src/content/prefs/sync-configs-table.tsx

🔇 Additional comments (1)

src/content/prefs/sync-configs-table.tsx (1)

97-97: Filter for deleted collections is correctly implemented.

The .filter((collection) => !collection.deleted) properly excludes deleted collections, and the placement before the map operation is optimal. The buildCollectionFullName() function uses the collection object's name property directly at execution time, which means renamed collections will display their current names if Zotero.Collections.getLoaded() returns up-to-date collection data.

However, confirming whether getLoaded() returns current collection names (as opposed to cached data) requires verification against Zotero's API behavior, which cannot be determined from code analysis alone.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Build Bot

✅ Successful build

⬇️ Download: notero-1.2.2-938

[github-actions]

Included in release v1.2.2