Skip to content

Conversation

@dvanoni
Copy link
Owner

@dvanoni dvanoni commented Jan 2, 2026

Remove workaround for jsdom missing TextEncoder/TextDecoder now that jsdom/jsdom#2524 is implemented.

Summary by CodeRabbit

  • Chores
    • Simplified test environment setup by removing unnecessary compatibility workarounds.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Walkthrough

The test setup file was simplified by removing imports of TextEncoder and TextDecoder from node:util and eliminating the associated workaround code that previously mapped these to global objects. The removal includes ts-expect-error comments that were part of this polyfill approach. The logger mock setup functionality remains intact with no changes to test behavior.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a workaround for jsdom TextEncoder/TextDecoder that is no longer needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 807716b and 80b219d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • test/setup-tests.ts
💤 Files with no reviewable changes (1)
  • test/setup-tests.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

🤖 Build Bot

✅ Successful build

⬇️ Download: notero-1.2.3-959

@dvanoni dvanoni merged commit 6b0d741 into main Jan 2, 2026
6 checks passed
@dvanoni dvanoni deleted the jsdom-textencoder branch January 2, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants