Fix: Search now properly respects databaseName parameter

[ebowman]

Summary

Fixed bug where the search function ignored the databaseName parameter when no group parameters were provided.

Problem

When the databaseName parameter was provided to the search function without any group parameters, the search would return results from all open databases instead of limiting results to the specified database.

Solution

When databaseName is provided without group parameters, the search is now scoped to that database's root group using targetDatabase.root(). This ensures that searches are properly limited to the specified database.

Testing

• Built successfully with npm run build
• Type checking passes with npm run type-check
• Tested with multiple databases to confirm search results are now properly scoped
• The fix is a minimal change (3 lines) that only affects the specific case where a database is specified without group parameters

[gemini-code-assist]

Summary of Changes

Hello @ebowman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the search functionality where the databaseName parameter was not properly respected when no group parameters were supplied. The change ensures that searches are accurately confined to the intended database, enhancing the precision and reliability of search results.

Highlights

• Search Function Fix: The search function now correctly scopes results to the specified database when the databaseName parameter is provided without any group parameters. Previously, it would incorrectly return results from all open databases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly identifies and fixes a bug where the databaseName parameter was being ignored. However, the current implementation introduces an unintended side effect: when no database or group is specified, the search scope is altered from all databases to only the current database. I've included a specific comment with a code suggestion to address this issue, ensuring the fix is precise and doesn't alter existing behavior for other use cases.

[dvcrn]

Nice, thanks for the PR! This LGTM

[dvcrn]

Released in https://github.com/dvcrn/mcp-server-devonthink/releases/tag/1.5.0