Skip to content

Commit 201a67b

Browse files
committed
fix: address remaining CodeRabbit feedback on PR #129
- openapi_test.go: assert exact swagger version "2.0" rather than non-empty - swagger.yaml + swagger.json: remove enforcement from SetBudgetRequest required array — handler defaults it to "hard" when omitted, so the spec was stricter than the implementation - swagger.yaml + swagger.json: change period_start format from date-time to date to match runtime serialization (YYYY-MM-DD) https://claude.ai/code/session_01MCDC1ZUBvDiYdi8n2ePzfJ
1 parent d2ec159 commit 201a67b

3 files changed

Lines changed: 7 additions & 9 deletions

File tree

packages/engine/internal/server/docs/swagger.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -860,8 +860,7 @@
860860
}
861861
},
862862
"required": [
863-
"monthly_token_limit",
864-
"enforcement"
863+
"monthly_token_limit"
865864
]
866865
},
867866
"server.StatusResponse": {
@@ -909,7 +908,7 @@
909908
},
910909
"period_start": {
911910
"type": "string",
912-
"format": "date-time"
911+
"format": "date"
913912
},
914913
"prompt_tokens": {
915914
"type": "integer"

packages/engine/internal/server/docs/swagger.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ definitions:
137137
type: integer
138138
required:
139139
- monthly_token_limit
140-
- enforcement
141140
type: object
142141
server.StatusResponse:
143142
properties:
@@ -169,7 +168,7 @@ definitions:
169168
completion_tokens:
170169
type: integer
171170
period_start:
172-
format: date-time
171+
format: date
173172
type: string
174173
prompt_tokens:
175174
type: integer

packages/engine/internal/server/openapi_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ func TestHandleOpenAPISpec(t *testing.T) {
2222
if err := json.Unmarshal(rec.Body.Bytes(), &doc); err != nil {
2323
t.Fatalf("response is not valid JSON: %v", err)
2424
}
25-
// Spec is Swagger 2.0 (generated by swaggo/swag); verify the version key is present.
26-
swaggerVer, _ := doc["swagger"].(string)
27-
if swaggerVer == "" {
28-
t.Errorf("expected swagger version string, got: %v", doc["swagger"])
25+
// Spec is Swagger 2.0 (generated by swaggo/swag); verify exact version.
26+
swaggerVer, ok := doc["swagger"].(string)
27+
if !ok || swaggerVer != "2.0" {
28+
t.Errorf("expected swagger version %q, got: %v", "2.0", doc["swagger"])
2929
}
3030
if doc["info"] == nil {
3131
t.Error("response missing 'info' field")

0 commit comments

Comments
 (0)