Skip to content

fix(site): deduplicate GitHub icon and improve mobile nav layout#23

Merged
michaelmcnees merged 1 commit into
mainfrom
fix/mobile-nav-cleanup
Mar 25, 2026
Merged

fix(site): deduplicate GitHub icon and improve mobile nav layout#23
michaelmcnees merged 1 commit into
mainfrom
fix/mobile-nav-cleanup

Conversation

@michaelmcnees

@michaelmcnees michaelmcnees commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Hide top-bar GitHub icon on mobile (lg:hidden) — the bottom bar already has one
  • Center the logo in the top bar on mobile (justify-center lg:justify-between)
  • Move the Menu button to the far right of the bottom bar for better thumb reachability

Bottom bar order (mobile)

Home | Docs | GitHub | Menu

Previously Menu was between Home and Docs, which felt awkward. Moving it to the far right puts it at the natural thumb position.

Test plan

  • Verify GitHub icon appears once on mobile (bottom bar only)
  • Verify GitHub icon appears in both bars on desktop (lg+)
  • Verify logo is centered in top bar on mobile
  • Verify Menu button is rightmost item in bottom bar on docs pages
  • Verify sidebar toggle still works from the Menu button

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Style
    • Improved responsive header layout: logo now centers on mobile devices while maintaining proper alignment on larger screens.
    • Adjusted GitHub link visibility to display only on larger screens for a cleaner mobile experience.
    • Reorganized navigation menu structure for better usability across different screen sizes.

…m nav

- Hide top-bar GitHub icon on mobile (lg:hidden) — bottom bar has it
- Center logo in top bar on mobile (justify-center lg:justify-between)
- Move Menu button to far right of bottom bar for thumb reachability

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 768e7b16-ce53-41bc-91e8-22d13eab4225

📥 Commits

Reviewing files that changed from the base of the PR and between 236e14f and 97c5153.

📒 Files selected for processing (1)
  • site/src/components/Nav.astro

📝 Walkthrough

Walkthrough

Navigation component layout updated to improve responsive design: desktop header alignment changed to center on mobile and justify-between on larger screens, GitHub link hidden on small screens, and mobile docs menu button repositioned within the conditional rendering flow.

Changes

Cohort / File(s) Summary
Navigation Component Updates
site/src/components/Nav.astro
Adjusted desktop header alignment from justify-between to justify-center lg:justify-between for mobile-first centering. Hidden GitHub link on small screens with hidden lg:block. Repositioned mobile docs menu button (bottom-nav-docs-btn) conditional block after Docs link while preserving its isDocs visibility logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hoppy hopping through the nav,
Mobile views now get to have,
Centered logos, links that hide,
Buttons shuffled side to side,
Responsive design—what a delight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: deduplicating the GitHub icon on mobile and improving mobile nav layout by centering the logo and repositioning the menu button.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-nav-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mantle with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97c5153
Status: ✅  Deploy successful!
Preview URL: https://30ee02c3.mantle-cxy.pages.dev
Branch Preview URL: https://fix-mobile-nav-cleanup.mantle-cxy.pages.dev

View logs

@michaelmcnees michaelmcnees merged commit db71d00 into main Mar 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant