runtime/CMakeLists.txt: Use target_include_directories #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, include directories are not propagated to targets calling target_link_libraries().
Contributor
|
I bumped CMake to 3.16 and fixed a lot of old warnings on custom builds, which makes this PR hopefully no longer needed, but if you have suggestions on top of that, we are in a better position to deal with it now. Bumped CMake to 3.16 in this commit: 385c27b Version 3.16 still allows Appveyor to test MSVC 2015 and should be recent enough. |
Contributor
|
Sorry, I thought this was another PR. This makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, include directories are not propagated to targets calling
target_link_libraries().