-
Notifications
You must be signed in to change notification settings - Fork 177
Add object tracking vignette #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JoelPasvolsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eordog, the doctest error on ValueError: array must not contain infs or NaNs is tricky but I can get it fixed locally (it requires NumPy > 2.6.2, for example 2.3.4 to recreate) with the changes in this review. I suspect that what is happening is that the test setups are getting mixed when run together before the code tests. I've reduced the setups to just two, one before the NL code examples and one for the CQM example, and separated these into two groups.
Locally when I run now I get just the expected NumPy errors on True_.
If this looks right to you, we'll see if a new commit runs in CI also without the ValueError: array must not contain infs or NaNs error, and then the remaining 8 NumPy errors will be fixed by @randomir's PR.
I'll review the rest separtely.
Co-authored-by: Joel Pasvolsky <[email protected]>
JoelPasvolsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
JoelPasvolsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
(Just suggest adding the two linespaces to the code I mentioned)
No description provided.