Return samples in pseudo_kl_divergence_loss
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be able to pass spinstring samples to pseudo_kl_divergence_loss Test return samples in pseudo_kl_divergence_loss Return samples in pseudo_kl_divergence_loss
VolodyaCO
force-pushed
the
pseudo_kl_loss-returns-samples
branch
from
812fb5c to
19508b3
Compare
kevinchern
approved these changes
Nov 19, 2025
Collaborator
There was a problem hiding this comment.
This pull request looks good to me.
--
My suggestions are:
- Make
samplesa required argument. The loss function should be decoupled from sampling; no sampling should be done in this loss function. - Make prefactor a required argument. In other parts of the code base where prefactor is an argument, it is defined as a mandatory keyword arg. The motivation was to mitigate bugs introduced by from using incorrect prefactor. We should be consistent and enforcing that.
--
@thisac should these suggestions addressed in separate PR?
Comment on lines
+4
to
+5
| The ``pseudo_kl_divergence_loss`` got spinstring samples from the GRBM. Now, | ||
| it is possible to pass spinstrings to the ``pseudo_kl_divergence_loss``. This |
Collaborator
There was a problem hiding this comment.
Clarify the difference between
The
pseudo_kl_divergence_lossgot spinstring samples from the GRBM.
and
Now, it is possible to pass spinstrings to the
pseudo_kl_divergence_loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pseudo_kl_divergence_loss, it would be nice to get the spinstrings sampled inside this function so that one can perform other calculations with those samples.