Skip to content

Revert GQL execution error handling#23

Merged
dwsutherland merged 2 commits intodwsutherland:graphql-core-v3from
MetRonnie:gql
May 13, 2025
Merged

Revert GQL execution error handling#23
dwsutherland merged 2 commits intodwsutherland:graphql-core-v3from
MetRonnie:gql

Conversation

@MetRonnie
Copy link
Copy Markdown

This raising of an exception was purposefully added in cylc#6578

Without it, there is no error indication in the UI or UIS logs. E.g. try changing 0 to (1 / 0) in the set_graph_window_extent resolver and see what happens when you change the N window:

if n_edge_distance >= 0:

@dwsutherland
Copy link
Copy Markdown
Owner

Ok, point taken..
image

I wasn't sure how far up the chain the raise would propagate

@dwsutherland dwsutherland merged commit c276c45 into dwsutherland:graphql-core-v3 May 13, 2025
dwsutherland added a commit that referenced this pull request May 13, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 13, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 13, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
@MetRonnie MetRonnie deleted the gql branch May 13, 2025 09:33
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 14, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 21, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request May 28, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 5, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 5, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 10, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 13, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 13, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
dwsutherland added a commit that referenced this pull request Jun 18, 2025
* Revert GQL execution error handling

* undo fail example

---------

Co-authored-by: David Sutherland <davidwollow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants