Fix deprecation warning for block_categories #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Deprecated: Hook block_categories is deprecated since
version 5.8.0! Use block_categories_all instead.
See:
https://developer.wordpress.org/reference/hooks/block_categories/
https://developer.wordpress.org/reference/hooks/block_categories_all/
snim2
force-pushed
the
fix/block-categories-deprecation
branch
from
b9c33fc
to
a0248d5
Compare
snim2
commented
Jun 18, 2024
| @@ -5,7 +5,7 @@ class BlockCategory implements \Dxw\Iguana\Registerable | |||
| { | |||
| public function register() | |||
| { | |||
| add_filter('block_categories', [$this, 'newBlocksCategory'], 10, 1); | |||
| add_filter('block_categories_all', [$this, 'newBlocksCategory'], 10, 1); | |||
| } | |||
|
|
|||
| public function newBlocksCategory($categories) | |||
There was a problem hiding this comment.
Note that we ignore the second parameter here which is the main thing that's changed in the new filter (WP_Post -> WP_Block_Editor_Context)
RobjS
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://developer.wordpress.org/reference/hooks/block_categories/
https://developer.wordpress.org/reference/hooks/block_categories_all/
Notes
This plugin is used on:
{ "0.2.0": [ "dxw/cass-review" ], "0.4.0": [ "dxw/dhsc-intranet" ], "0.4.1": [ "dxw/saluki-test-site", "dxw/settle", "dxw/valleys-to-coast" ] }Testing