Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby #1324

Merged
merged 2 commits into from
May 29, 2024
Merged

Upgrade Ruby #1324

merged 2 commits into from
May 29, 2024

Conversation

yndajas
Copy link
Contributor

@yndajas yndajas commented May 29, 2024

This upgrades Ruby, in the process upgrading sass-embedded and restoring it as a direct dependency, which fixes a Netlify build failure

Closes #1313

Copy link

netlify bot commented May 29, 2024

Deploy Preview for laughing-payne-b9fbd2 ready!

Name Link
🔨 Latest commit 5283cae
🔍 Latest deploy log https://app.netlify.com/sites/laughing-payne-b9fbd2/deploys/6656fa5f92ee0e0008f90a85
😎 Deploy Preview https://deploy-preview-1324--laughing-payne-b9fbd2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

There are no issues running the server locally, but Netlify is
struggling to install `sass-embedded`, which is blocking our Ruby
upgrade. The accessibility manual is at 1.77.2, which installs fine on
Netlify. This upgrades the gem to 1.77.2 for the playbook

This was removed as a direct dependency in 033d3be when addressing a
local development compatibility issue, but evidently it's remained or
reappeared as an indirect dependency. This restores it as a direct
dependency (originally added in a8981e9), in line with the accessibility
manual, which should mean that Renovate keeps it up to date. Everything
continues to run fine locally
Copy link
Contributor

@snim2 snim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good :)

@yndajas yndajas merged commit 521d000 into main May 29, 2024
6 checks passed
@yndajas yndajas deleted the upgrade-ruby branch May 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants