Skip to content

Fix the S3 bucket name passed to the snapshot task. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vincentwschau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the S3 bucket name passed to the snapshot task. #55

vincentwschau wants to merge 1 commit into from

Conversation

@vincentwschau
Copy link
Contributor

@vincentwschau vincentwschau commented Nov 8, 2023

Now that the name variable doesn't always = the bucket name, pass the bucket id to the snapshot task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiajames jiajames Awaiting requested review from jiajames

@lucas-dydx lucas-dydx Awaiting requested review from lucas-dydx

2 more reviewers

@Christopher-Li Christopher-Li Christopher-Li approved these changes

@dydxwill dydxwill dydxwill approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vincentwschau @Christopher-Li @dydxwill