Skip to content

feat(otcbuyback): invariants#2034

Merged
mtsitrin merged 18 commits intomainfrom
2020-xotcbuyback-invariants
Oct 9, 2025
Merged

feat(otcbuyback): invariants#2034
mtsitrin merged 18 commits intomainfrom
2020-xotcbuyback-invariants

Conversation

@mtsitrin
Copy link
Copy Markdown
Contributor

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin linked an issue Sep 30, 2025 that may be closed by this pull request
@mtsitrin mtsitrin changed the base branch from main to refactor/otcbuyback_comments September 30, 2025 08:21
@mtsitrin mtsitrin marked this pull request as ready for review September 30, 2025 12:10
@mtsitrin mtsitrin requested a review from a team as a code owner September 30, 2025 12:10
Base automatically changed from refactor/otcbuyback_comments to main September 30, 2025 13:39
Comment thread x/otcbuyback/keeper/invariants.go Outdated
keruch
keruch previously approved these changes Sep 30, 2025
@keruch keruch self-requested a review October 6, 2025 07:58
@mtsitrin mtsitrin merged commit 2b587b1 into main Oct 9, 2025
5 checks passed
@mtsitrin mtsitrin deleted the 2020-xotcbuyback-invariants branch October 9, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/otcbuyback: invariants

2 participants