Merged
Conversation
Contributor
|
we have to wait until the deps moved on (e.g. greenlets of sqlalchemy fail) |
Collaborator
Author
|
Yes and some other ones as well |
3984114 to
778f5ab
Compare
Contributor
|
python 3.13 is out. There were some arbitary changes from wherever, I resetted the PR to a clean state which hopefully succeeds. |
devkral
approved these changes
Jan 8, 2025
Contributor
devkral
left a comment
There was a problem hiding this comment.
Just a little merge conflict. Hopefully it works now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also waiting for the libraries to move to Python 3.13. Then we can remove the 3.8.
This is expected to fail until 3.13 is fully out and the asyncpg and so on update.