Fix for CameraView blacks outs and Aspect ratio iteration issue #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed layout issues with the capture FAB in the demo (google#120)
getSupportedAspectRatio returns aspect ratios of preview sizes for which picture sizes doesn't exist. This results in NullPointerException. So getSuportedAspectRatio now depends on suported Picture Sizes Resolves: google#88
TextureView/SurfaceView was added twice to CameraView. So when requestLayout is called on CameraView blank surface comes up. Note that CameraView parent is FrameLayout, so last added view comes in front. In the solution, I have simply removed last added TextureView/SurfaceView before adding new TextureView/SurfaceView inside start function on CameraView. This makes sure that new Surface is created for each start. Resolves: google#111
It is not safe to traverse and remove from the same set. It will result is `ConcurrentModificationException` or `NullpointerException` in case of ArrayMap. So new `Set<AspectRatio>` was added to traverse the ArrayMap. Check commit: 6ceaf86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google#125