Dev/skruk/telemetry types config#19
Merged
sebastiankruk merged 23 commits intodynatrace-oss:release/0.9.2from Nov 3, 2025
Merged
Dev/skruk/telemetry types config#19sebastiankruk merged 23 commits intodynatrace-oss:release/0.9.2from
sebastiankruk merged 23 commits intodynatrace-oss:release/0.9.2from
Conversation
…er traceability
…; query_history still wip
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements configurable telemetry types for plugins, allowing granular control over which telemetry channels (logs, metrics, events, spans, biz_events) each plugin can use. The changes refactor plugin return types from tuples to dictionaries and introduce a NoOpTelemetry class to disable specific telemetry types at runtime.
Key changes:
- Plugin
process()methods now returnDict[str, Dict[str, int]]instead of tuples for better clarity - Added
TELEMETRYconfiguration to all plugin config files specifying allowed telemetry types - Introduced
NoOpTelemetryclass to handle disabled telemetry gracefully - Test infrastructure updated to validate telemetry type disabling functionality
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/dtagent/plugins/*.py | Refactored all plugin process() methods to return dictionaries with telemetry counts |
| src/dtagent/plugins/.config/.json | Added TELEMETRY configuration arrays to specify allowed telemetry types per plugin |
| src/dtagent/otel/init.py | Introduced NoOpTelemetry class for disabled telemetry handling |
| src/dtagent/agent.py | Modified to inject NoOpTelemetry instances for disabled telemetry types |
| src/dtagent/init.py | Added telemetry_allowed set tracking globally enabled telemetry types |
| test/plugins/*.py | Updated all plugin tests to use new execute_telemetry_test helper with telemetry disabling |
| test/_utils.py | Added execute_telemetry_test() helper for testing with disabled telemetry |
| test/_mocks/telemetry.py | Updated to skip validation for disabled telemetry types |
| PLUGINS.md, ARCHITECTURE.md | Updated documentation for new return format and telemetry configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
micjaki
approved these changes
Nov 3, 2025
dorian-krefft-dt
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.