Skip to content

[DQL] (chore) Improving messages usage in DQL components#120

Merged
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/improving-messages
Feb 7, 2026
Merged

[DQL] (chore) Improving messages usage in DQL components#120
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/improving-messages

Conversation

@dorian-krefft-dt
Copy link
Collaborator

In previous refactoring sessions the classes were migrated, but used messages keys were not updated to match the purpose.

In previous refactoring sessions the classes were migrated, but used messages keys were not updated to match the purpose.
@dorian-krefft-dt dorian-krefft-dt self-assigned this Feb 7, 2026
Copilot AI review requested due to automatic review settings February 7, 2026 16:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DQL UI components to use message keys that better match the refactored class/component structure, replacing legacy action/run-configuration keys and hardcoded strings.

Changes:

  • Reorganized and renamed a large set of DQLBundle.properties keys to align with component responsibilities (execution, results, metadata, editor actions).
  • Rewired multiple UI panels/actions to use the new message keys (tables, record/metadata views, execution summary/error panels).
  • Replaced DQLProcessHandler hardcoded console strings with localized bundle messages; added user notifications for missing tenant/missing configuration.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/main/resources/messages/DQLBundle.properties Introduces new component/editor/processHandler message keys and removes legacy ones
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLTableResultPanel.java Switches table/record UI text to new result-related keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLRecordPanel.java Switches single-record column titles to new keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLMetadataPanel.java Switches metadata labels/columns to new execution-metadata keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionSummary.java Switches summary title/tooltip to new executionSummary keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionResult.java Switches toolbar action titles/dialog copy to new executionResult keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionErrorPanel.java Switches exception mapping messages to new executionError keys
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecuteInProgressPanel.java Switches in-progress strings to new executionInProgress keys
src/main/java/pl/thedeem/intellij/dql/exec/DQLProcessHandler.java Localizes process console output via bundle keys
src/main/java/pl/thedeem/intellij/dql/exec/DQLExecutionService.java Switches “open in new tab/close” action titles to new service keys
src/main/java/pl/thedeem/intellij/dql/editor/actions/TenantSelectorAction.java Switches tenant selector toolbar text to new editor action key
src/main/java/pl/thedeem/intellij/dql/editor/actions/StartStopDQLExecutionAction.java Switches execute/stop/rerun titles to new editor action keys
src/main/java/pl/thedeem/intellij/dql/editor/actions/SaveQueryConfigurationAction.java Switches save-as-run-config text + adds notification on missing configuration
src/main/java/pl/thedeem/intellij/dql/editor/actions/QueryConfigurationOptionsAction.java Switches toggle label to new editor action key
src/main/java/pl/thedeem/intellij/dql/components/QueryTimeframeConfigurationComponent.java Switches timeframe placeholders/tooltips and predefined timeframe menu text
src/main/java/pl/thedeem/intellij/dql/components/QueryConfigurationComponent.java Switches numeric field placeholders/tooltips to new component keys
src/main/java/pl/thedeem/intellij/dql/actions/ExecuteDQLQueryAction.java Adds notification when trying to execute without a selected tenant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dorian-krefft-dt dorian-krefft-dt merged commit fd70b7d into main Feb 7, 2026
12 of 13 checks passed
@dorian-krefft-dt dorian-krefft-dt deleted the feature/dql/improving-messages branch February 8, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants