[DQL] (chore) Improving messages usage in DQL components#120
[DQL] (chore) Improving messages usage in DQL components#120dorian-krefft-dt merged 2 commits intomainfrom
Conversation
In previous refactoring sessions the classes were migrated, but used messages keys were not updated to match the purpose.
There was a problem hiding this comment.
Pull request overview
Updates DQL UI components to use message keys that better match the refactored class/component structure, replacing legacy action/run-configuration keys and hardcoded strings.
Changes:
- Reorganized and renamed a large set of
DQLBundle.propertieskeys to align with component responsibilities (execution, results, metadata, editor actions). - Rewired multiple UI panels/actions to use the new message keys (tables, record/metadata views, execution summary/error panels).
- Replaced
DQLProcessHandlerhardcoded console strings with localized bundle messages; added user notifications for missing tenant/missing configuration.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/messages/DQLBundle.properties | Introduces new component/editor/processHandler message keys and removes legacy ones |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLTableResultPanel.java | Switches table/record UI text to new result-related keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLRecordPanel.java | Switches single-record column titles to new keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLMetadataPanel.java | Switches metadata labels/columns to new execution-metadata keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionSummary.java | Switches summary title/tooltip to new executionSummary keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionResult.java | Switches toolbar action titles/dialog copy to new executionResult keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecutionErrorPanel.java | Switches exception mapping messages to new executionError keys |
| src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecuteInProgressPanel.java | Switches in-progress strings to new executionInProgress keys |
| src/main/java/pl/thedeem/intellij/dql/exec/DQLProcessHandler.java | Localizes process console output via bundle keys |
| src/main/java/pl/thedeem/intellij/dql/exec/DQLExecutionService.java | Switches “open in new tab/close” action titles to new service keys |
| src/main/java/pl/thedeem/intellij/dql/editor/actions/TenantSelectorAction.java | Switches tenant selector toolbar text to new editor action key |
| src/main/java/pl/thedeem/intellij/dql/editor/actions/StartStopDQLExecutionAction.java | Switches execute/stop/rerun titles to new editor action keys |
| src/main/java/pl/thedeem/intellij/dql/editor/actions/SaveQueryConfigurationAction.java | Switches save-as-run-config text + adds notification on missing configuration |
| src/main/java/pl/thedeem/intellij/dql/editor/actions/QueryConfigurationOptionsAction.java | Switches toggle label to new editor action key |
| src/main/java/pl/thedeem/intellij/dql/components/QueryTimeframeConfigurationComponent.java | Switches timeframe placeholders/tooltips and predefined timeframe menu text |
| src/main/java/pl/thedeem/intellij/dql/components/QueryConfigurationComponent.java | Switches numeric field placeholders/tooltips to new component keys |
| src/main/java/pl/thedeem/intellij/dql/actions/ExecuteDQLQueryAction.java | Adds notification when trying to execute without a selected tenant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLExecuteInProgressPanel.java
Show resolved
Hide resolved
src/main/java/pl/thedeem/intellij/dql/editor/actions/SaveQueryConfigurationAction.java
Show resolved
Hide resolved
src/main/java/pl/thedeem/intellij/dql/editor/actions/SaveQueryConfigurationAction.java
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
In previous refactoring sessions the classes were migrated, but used messages keys were not updated to match the purpose.