Skip to content

Comments

[DQL] Switching to a new Inlay engine#127

Merged
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/new-inlays
Feb 10, 2026
Merged

[DQL] Switching to a new Inlay engine#127
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/new-inlays

Conversation

@dorian-krefft-dt
Copy link
Collaborator

No description provided.

@dorian-krefft-dt dorian-krefft-dt self-assigned this Feb 9, 2026
Copilot AI review requested due to automatic review settings February 9, 2026 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches DQL parameter inlay hints to the newer IntelliJ InlayHintsProvider engine and introduces PSI support to cache/query defined variables at the query level.

Changes:

  • Replaced legacy codeInsight.parameterNameHints provider with codeInsight.inlayProvider and added configurable inlay settings UI.
  • Added QueryElement PSI mixin with caching for defined variables; updated variables service to use it.
  • Updated bundle messages, grammar, and presentation text to support the new inlay/presentation features.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/main/resources/messages/DQLBundle.properties Adds new UI strings for inlay hint settings and query presentation.
src/main/resources/META-INF/plugin.xml Switches extension registration to new inlay provider and removes old parameter hints registrations.
src/main/java/pl/thedeem/intellij/dqlpart/DQLPartLanguage.java Makes DQLPart a kind-of the main DQL language (dialect relationship).
src/main/java/pl/thedeem/intellij/dql/services/variables/DQLVariablesServiceImpl.java Updates variable discovery to use query-level cached variables.
src/main/java/pl/thedeem/intellij/dql/services/variables/DQLVariablesService.java Tightens nullability contract for getDefaultVariablesFile.
src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/VariableElementImpl.java Changes variable value resolution behavior when definition is not JSON-backed.
src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/QueryElementImpl.java Adds cached computation of defined variables and query presentation.
src/main/java/pl/thedeem/intellij/dql/psi/elements/QueryElement.java Introduces PSI API for query-defined variables.
src/main/java/pl/thedeem/intellij/dql/highlighting/hints/DQLParameterNameHintsProvider.java New inlay hints provider implementation + settings UI + preview text.
src/main/grammar/dql.bnf Adds mixin/implements for query PSI element.
CHANGELOG.md Documents the switch to the new inlay provider/settings location.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dorian-krefft-dt dorian-krefft-dt merged commit 6252664 into main Feb 10, 2026
9 checks passed
@dorian-krefft-dt dorian-krefft-dt deleted the feature/dql/new-inlays branch February 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant