[DQL] Switching to a new Inlay engine#127
Conversation
There was a problem hiding this comment.
Pull request overview
Switches DQL parameter inlay hints to the newer IntelliJ InlayHintsProvider engine and introduces PSI support to cache/query defined variables at the query level.
Changes:
- Replaced legacy
codeInsight.parameterNameHintsprovider withcodeInsight.inlayProviderand added configurable inlay settings UI. - Added
QueryElementPSI mixin with caching for defined variables; updated variables service to use it. - Updated bundle messages, grammar, and presentation text to support the new inlay/presentation features.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/messages/DQLBundle.properties | Adds new UI strings for inlay hint settings and query presentation. |
| src/main/resources/META-INF/plugin.xml | Switches extension registration to new inlay provider and removes old parameter hints registrations. |
| src/main/java/pl/thedeem/intellij/dqlpart/DQLPartLanguage.java | Makes DQLPart a kind-of the main DQL language (dialect relationship). |
| src/main/java/pl/thedeem/intellij/dql/services/variables/DQLVariablesServiceImpl.java | Updates variable discovery to use query-level cached variables. |
| src/main/java/pl/thedeem/intellij/dql/services/variables/DQLVariablesService.java | Tightens nullability contract for getDefaultVariablesFile. |
| src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/VariableElementImpl.java | Changes variable value resolution behavior when definition is not JSON-backed. |
| src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/QueryElementImpl.java | Adds cached computation of defined variables and query presentation. |
| src/main/java/pl/thedeem/intellij/dql/psi/elements/QueryElement.java | Introduces PSI API for query-defined variables. |
| src/main/java/pl/thedeem/intellij/dql/highlighting/hints/DQLParameterNameHintsProvider.java | New inlay hints provider implementation + settings UI + preview text. |
| src/main/grammar/dql.bnf | Adds mixin/implements for query PSI element. |
| CHANGELOG.md | Documents the switch to the new inlay provider/settings location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/VariableElementImpl.java
Show resolved
Hide resolved
src/main/java/pl/thedeem/intellij/dql/psi/elements/impl/QueryElementImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/thedeem/intellij/dql/services/variables/DQLVariablesServiceImpl.java
Show resolved
Hide resolved
src/main/java/pl/thedeem/intellij/dql/highlighting/hints/DQLParameterNameHintsProvider.java
Show resolved
Hide resolved
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
No description provided.