Skip to content

Comments

[DQL] Detecting DQL Expression files#132

Merged
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/detecting-expr-files
Feb 13, 2026
Merged

[DQL] Detecting DQL Expression files#132
dorian-krefft-dt merged 2 commits intomainfrom
feature/dql/detecting-expr-files

Conversation

@dorian-krefft-dt
Copy link
Collaborator

In cases where a DQL expression is written in a DQL file, the inspection will suggest renaming it into the .dqlexpr file.

In cases where a DQL expression is written in a DQL file, the inspection will suggest renaming it into the `.dqlexpr` file.
@dorian-krefft-dt dorian-krefft-dt self-assigned this Feb 13, 2026
Copilot AI review requested due to automatic review settings February 13, 2026 15:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces detection of DQL expression files to help users properly categorize their DQL content. When a DQL file contains only expressions without valid command context, the inspection suggests renaming it to use the .dqlexpr extension. This enables proper parsing and validation of expression-only content.

Changes:

  • Added a new PotentialExpressionFile inspection that detects when DQL files contain expressions without valid query commands
  • Updated external validation and autocomplete features to skip .dqlexpr files since they don't contain full queries
  • Enhanced the RenameFileQuickFix to support renaming files without starting a write action (allowing the rename processor to handle transactions)

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/main/resources/messages/DQLBundle.properties Added message keys for the new inspection and updated the rename file message to be more generic
src/main/resources/inspectionDescriptions/DQLPotentialExpressionFile.html Added HTML documentation describing the new inspection
src/main/resources/META-INF/plugin.xml Registered the new PotentialExpressionFile inspection
src/main/java/pl/thedeem/intellij/dql/inspections/fixes/RenameFileQuickFix.java Added startInWriteAction() override to prevent automatic write action wrapping
src/main/java/pl/thedeem/intellij/dql/inspections/external/DQLVerificationAnnotator.java Updated to skip external validation for .dqlexpr files
src/main/java/pl/thedeem/intellij/dql/inspections/commands/PotentialExpressionFileInspection.java New inspection implementation that detects potential expression files
src/main/java/pl/thedeem/intellij/dql/completion/DQLExternalCompletionContributor.java Updated to skip Dynatrace autocomplete for .dqlexpr files
CHANGELOG.md Added entry documenting the new quick fix for renaming to .dqlexpr

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dorian-krefft-dt dorian-krefft-dt merged commit 238ffdf into main Feb 13, 2026
9 checks passed
@dorian-krefft-dt dorian-krefft-dt deleted the feature/dql/detecting-expr-files branch February 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant