Skip to content

Comments

[DQL] Added toggle button for external DQL validations#134

Merged
dorian-krefft-dt merged 4 commits intomainfrom
feature/dql/toggle-external-validation
Feb 14, 2026
Merged

[DQL] Added toggle button for external DQL validations#134
dorian-krefft-dt merged 4 commits intomainfrom
feature/dql/toggle-external-validation

Conversation

@dorian-krefft-dt
Copy link
Collaborator

@dorian-krefft-dt dorian-krefft-dt commented Feb 14, 2026

image

@dorian-krefft-dt dorian-krefft-dt self-assigned this Feb 14, 2026
Copilot AI review requested due to automatic review settings February 14, 2026 11:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a toggle button to enable/disable external DQL validation on a per-file basis. Previously, this validation could only be controlled globally through plugin settings. The PR also includes a refactoring that changes several Objects.requireNonNullElse calls to Objects.requireNonNullElseGet for better performance by using lazy evaluation.

Changes:

  • Added a new toggle action (ToggleExternalValidationAction) that allows users to control external validation per file via the DQL Execution Toolbar
  • Modified DQLVerificationAnnotator to check per-file validation preference first, falling back to global settings
  • Refactored multiple instances of Objects.requireNonNullElse to Objects.requireNonNullElseGet for lazy evaluation of default values

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/main/resources/messages/DQLBundle.properties Added localized strings for the new toggle validation action
src/main/java/pl/thedeem/intellij/dql/settings/DQLSettings.java Added EXTERNAL_VALIDATION_ENABLED Key for storing per-file validation preference
src/main/java/pl/thedeem/intellij/dql/services/query/DQLQueryConfigurationServiceImpl.java Refactored to use lazy evaluation in configuration creation methods
src/main/java/pl/thedeem/intellij/dql/inspections/external/DQLVerificationAnnotator.java Updated to check per-file validation setting before global setting; added @NotNull annotations
src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLQueryConsolePanel.java Refactored to use lazy evaluation for query configuration
src/main/java/pl/thedeem/intellij/dql/editor/gutter/DQLQueryConfigurationLineMarkerProvider.java Added data key to hide validation option in gutter marker context
src/main/java/pl/thedeem/intellij/dql/editor/actions/ToggleExternalValidationAction.java New toggle action implementation for per-file external validation control
src/main/java/pl/thedeem/intellij/dql/editor/actions/StartStopDQLExecutionAction.java Refactored to use lazy evaluation for configuration retrieval
src/main/java/pl/thedeem/intellij/dql/editor/actions/QueryConfigurationAction.java Added toggle validation action to the query configuration menu
src/main/java/pl/thedeem/intellij/dql/documentation/providers/BaseDocumentationProvider.java Refactored to use lazy evaluation for documentation message retrieval
src/main/java/pl/thedeem/intellij/dql/actions/ExecuteDQLQueryAction.java Refactored to use lazy evaluation for execution name
src/main/java/pl/thedeem/intellij/dpl/psi/elements/impl/ExpressionElementImpl.java Code formatting improvements (line breaks)
src/main/java/pl/thedeem/intellij/dpl/inspections/configuration/ConfigurationNotSupportedInspection.java Code formatting improvements (line breaks)
src/main/java/pl/thedeem/intellij/dpl/documentation/providers/DPLConfigurationParameterDocumentationProvider.java Refactored to use lazy evaluation for bundle message retrieval
src/main/java/pl/thedeem/intellij/dpl/definition/DPLDefinitionServiceImpl.java Code formatting improvements (line breaks)
src/main/java/pl/thedeem/intellij/common/sdk/errors/DQLInvalidResponseException.java Refactored to use lazy evaluation with method reference
src/main/java/pl/thedeem/intellij/common/sdk/errors/DQLDetailedErrorException.java Code formatting improvements (line breaks)
CHANGELOG.md Documented the new per-file validation toggle feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dorian-krefft-dt dorian-krefft-dt merged commit ac7bc46 into main Feb 14, 2026
9 checks passed
@dorian-krefft-dt dorian-krefft-dt deleted the feature/dql/toggle-external-validation branch February 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant