Open
Conversation
Kirdock
force-pushed
the
test/refactor-e2e
branch
5 times, most recently
from
5a37c74 to
6de3ec4
Compare
Kirdock
changed the title
Kirdock
changed the title
Kirdock
force-pushed
the
test/refactor-e2e
branch
2 times, most recently
from
642bab5 to
a24d852
Compare
Kirdock
force-pushed
the
test/refactor-e2e
branch
6 times, most recently
from
bafc2b0 to
ffe75d0
Compare
Process group IDs most probably don't exist on a different tenant. Because they can't be created manually but via the OneAgent, a data source that matches via a name is the best way forward here
Instead of using a static mobile application ID that may not exist, we are now creating a mobile application first if we need one.
Some resources need additional creation time. Because of that, the "time_sleep" resource is needed, which must also be defined in the ExternalProviders test case options of the TF testing framework. Therefore, the ExternalProviders are now exposed in the test options, so that resources that need them can set them.
… time Some examples have the same dependency to a certain resource (e.g., request attributes or management zones). Because the creation may take some time, it makes sense to create dependencies once instead for each example. With this the examples are concatenated and executed once. It basically merges several tf files into one
…static one Instead of using a static browser monitor ID that may not exist, we now create a browser monitor first if needed.
Instead of using a static credential vault ID that may not exist, we now create a dummy credential first if needed.
Kirdock
force-pushed
the
test/refactor-e2e
branch
from
ffe75d0 to
fd6f0b9
Compare
Instead of using a static geo location ID that may not exist, we are now fetching by name
Instead of using a static dashboard ID that may not exist, we now create one first if needed.
Removes the static request attribute and management zone dependency for `dynatrace_calculated_service_metric` and creates them on demand
The previous dashboard relied on installed extensions and was based on old configurations (not Data Explorer). With this change, it's more independent
Kirdock
force-pushed
the
test/refactor-e2e
branch
from
fd6f0b9 to
bb214c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR of multiple. More are incoming later.
This one mostly touches the dependencies of and to V1 resources
Why this PR?
Some E2E tests (e.g., examples) refer to existing objects (e.g., management zones, request attributes, process groups, etc.). As this can easily break if someone just deletes something in the environment, we need to remove hardcoded IDs and create the needed dependencies on demand.
What has changed?
E2E tests are more stable. Changes in the environment will less likely cause E2Es to fail.
How does it do it?
Hardcoded IDs in E2E (examples) are removed, and referenced resources are created via resource or fetched via data source within the example.
This includes
For
dynatrace_calculated_web_metric, I combined the Terraform files. Web applications take longer than 1m30s to create, that's why I decided to join the configs and create them all at once, referring to the same web applicationAlso changed some payloads.
How is it tested?
That's literally about tests
How does it affect users?
They will see better documentation if the touched examples are included. They will now see the correct relation between resources or data sources.
Issue: CA-17770
Additional notes:
There is still one small dependency. Process groups can't be manually created. Also, a data source can't be used, as process groups fade out after 3 days, meaning the OneAgent would have to run continuously. Even though process groups time out, they can still be used and queried via ID. Therefore, the best approach here is to provide the process group ID.
This implementation already relies on the created setup-resources of #986