Open
Conversation
✅ Conventional Commits check passedAll commit messages in this PR now follow the Conventional Commits specification. 🎉 |
PakeMPC
force-pushed
the
fix-camerashake-params
branch
from
e3f81c2 to
aa7f410
Compare
PakeMPC
force-pushed
the
fix-camerashake-params
branch
from
d45ef30 to
3a711fc
Compare
jaromil
approved these changes
Apr 20, 2026
Member
|
Can you rebase this on current master? there are conflicts detected. Also can you have a look at https://github.com/dyne/frei0r/pull/271/changes maybe there is something relevant to merge from there too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the parameter normalization to [0.0, 1.0] and adds the missing f0r_param_info explanations requested in #256.