Skip to content

BugFix: Fix block size in matrixMutiplyVector #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyzheng merged 1 commit into from
Sep 10, 2025
Merged

BugFix: Fix block size in matrixMutiplyVector #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/module_hsolver/kernels/cuda/math_kernel_op.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,7 @@ template <>
void matrixMutiplyVector<double, base_device::DEVICE_GPU>::operator()(const base_device::DEVICE_GPU *d, const int &m, const int &n,
double *a, const int &lda, const double *v, const double alpha, double *c, const int &ldc){
dim3 thread(16, 16, 1);
dim3 block((m + thread.x - 1) / thread.x, (m + thread.y - 1) / thread.y, 1);
dim3 block((m + thread.x - 1) / thread.x, (n + thread.y - 1) / thread.y, 1);
matrix_multiply_vector_kernel<double, double> <<<block, thread >>>(m, n, a, lda,
v, alpha, c, ldc);
cudaCheckOnDebug();
Expand All @@ -1208,7 +1208,7 @@ template <>
void matrixMutiplyVector<std::complex<float>, base_device::DEVICE_GPU>::operator()(const base_device::DEVICE_GPU *d, const int &m, const int &n,
std::complex<float> *a, const int &lda, const float *v, const float alpha, std::complex<float> *c, const int &ldc){
dim3 thread(16, 16, 1);
dim3 block((m + thread.x - 1) / thread.x, (m + thread.y - 1) / thread.y, 1);
dim3 block((m + thread.x - 1) / thread.x, (n + thread.y - 1) / thread.y, 1);
matrix_multiply_vector_kernel<thrust::complex<float>, float> <<<block, thread >>>(m, n, reinterpret_cast<thrust::complex<float>*>(a), lda,
v, alpha, reinterpret_cast<thrust::complex<float>*>(c), ldc);
cudaCheckOnDebug();
Expand Down
4 changes: 2 additions & 2 deletions source/module_hsolver/kernels/rocm/math_kernel_op.hip.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ template <>
void matrixMutiplyVector<double, base_device::DEVICE_GPU>::operator()(const base_device::DEVICE_GPU *d, const int &m, const int &n,
double *a, const int &lda, const double *v, const double alpha, double *c, const int &ldc){
dim3 thread(16, 16, 1);
dim3 block((m + thread.x - 1) / thread.x, (m + thread.y - 1) / thread.y, 1);
dim3 block((m + thread.x - 1) / thread.x, (n + thread.y - 1) / thread.y, 1);
hipLaunchKernelGGL(HIP_KERNEL_NAME(matrix_multiply_vector_kernel<double, double>), block, thread, 0, 0, m, n, a, lda,
v, alpha, c, ldc);
hipCheckOnDebug();
Expand All @@ -1122,7 +1122,7 @@ template <>
void matrixMutiplyVector<std::complex<float>, base_device::DEVICE_GPU>::operator()(const base_device::DEVICE_GPU *d, const int &m, const int &n,
std::complex<float> *a, const int &lda, const float *v, const float alpha, std::complex<float> *c, const int &ldc){
dim3 thread(16, 16, 1);
dim3 block((m + thread.x - 1) / thread.x, (m + thread.y - 1) / thread.y, 1);
dim3 block((m + thread.x - 1) / thread.x, (n + thread.y - 1) / thread.y, 1);
hipLaunchKernelGGL(HIP_KERNEL_NAME(matrix_multiply_vector_kernel<thrust::complex<float>, float>), block, thread, 0, 0, m, n, reinterpret_cast<thrust::complex<float>*>(a), lda,
v, alpha, reinterpret_cast<thrust::complex<float>*>(c), ldc);
hipCheckOnDebug();
Expand Down
Loading