Skip to content

Conversation

@e-kotov
Copy link
Owner

@e-kotov e-kotov commented Jan 11, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 11, 2026 16:34
@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.80%. Comparing base (b69794a) to head (40ef7d9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
R/java_env.R 91.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   85.97%   86.80%   +0.82%     
==========================================
  Files          20       20              
  Lines        1954     1993      +39     
==========================================
+ Hits         1680     1730      +50     
+ Misses        274      263      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where macOS systems were incorrectly picking up Java stub executables from /usr/bin/java instead of actual Java installations. The fix includes enhanced path detection, symlink resolution, AppleDouble file filtering, improved version parsing, and comprehensive test coverage.

Changes:

  • Enhanced macOS-specific Java detection to filter out /usr and properly resolve symlinks
  • Improved Java version parsing to handle multi-line output and noise like environment variable messages
  • Added robust extraction logic to ignore macOS metadata files (AppleDouble ._ files)

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/testthat/test-java_version_parsing.R Comprehensive tests for Java version string parsing across various distributions
tests/testthat/test-java_unpack_logic.R Tests for directory extraction logic with AppleDouble file handling
tests/testthat/test-internal_utilities_symlinks.R Tests for symlink resolution including circular references and relative paths
tests/testthat/test-java_full-cycle-live.R Simplified verification output logic
tests/testthat/test-java_find.R Added mocking for robust path normalization testing
tests/testthat/test-java_env_version_impl.R Added dummy executable creation for path detection tests
tests/testthat/test-java_build_env_mocked.R Wrapped calls with suppressWarnings to handle expected warnings
R/java_unpack.R Enhanced extraction logic with new helper function and macOS fallback handling
R/java_find.R Refactored symlink resolution, added /usr filtering for macOS
R/java_env.R Improved version parsing, fixed cache key handling, added macOS DYLD_LIBRARY_PATH handling
R/internal_utilities.R Added resolve_symlinks utility, ._find_extracted_dir helper, AppleDouble filtering
_pkgdown.yml Reorganized navbar structure for articles

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@e-kotov e-kotov merged commit cbc4a78 into main Jan 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants