S28 module: Java decompiler and analyzer / fix p10, add vineflower #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues in the P10 VMDK extractor module and adds the Vineflower Java decompiler to the installer dependencies.
- Replaces
guestmountwithguestfishfor VMDK extraction to improve reliability - Adds Vineflower 1.11.2 Java decompiler to the installation process
- Expands grepit rule filtering to skip rules with ratings 6-9 (previously only 9)
- Removes unnecessary
nosemgrepcomments from example strings
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/P10_vmdk_extractor.sh | Refactors VMDK extraction to use guestfish tgz-out instead of guestmount, moving from mount-based to tar-based extraction |
| modules/S99_grepit.sh | Expands rule filtering regex to skip 6-9 rated rules; removes unnecessary nosemgrep comments from example strings; fixes function name typo from search to grepit_search |
| modules/L22_upnp_hnap_checks.sh | Code formatting improvements (whitespace cleanup) |
| installer/I20_sourcecode_check.sh | Adds download and installation of Vineflower 1.11.2 Java decompiler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-1-k-3
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
No deep Java analysis
After seeing the great work of @floyd-fuh with crass we also integrated vineflower-1.11.2.jar into EMBA
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
bump base image