Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplaced order icons: Make css selector for order icon padding more selective #2134

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix misplaced order icons: Make css selector for order icon padding more selective #2134

merged 2 commits into from
Mar 25, 2024

Conversation

richardebeling
Copy link
Member

fixes #2033

Kakadus
Kakadus requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlapping is fixed but still looks weird for me:
image
The arrows should not be transparent but just gray, right?

janno42
janno42 reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me but we should replace the opacity with gray and black font color to fix @Kakadus's issue

@janno42 janno42 mentioned this pull request Mar 14, 2024
Merged
@Kakadus Kakadus merged commit 1a7783e into e-valuation:main Mar 25, 2024
12 checks passed
@richardebeling richardebeling deleted the fix-ordering-icons branch December 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@Kakadus Kakadus Kakadus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ordering icons misplaced in table headers
3 participants
@richardebeling @janno42 @Kakadus