Skip to content

Customizable evaluation results filters#2232

Merged
janno42 merged 68 commits intoe-valuation:mainfrom
ybrnr:iss1786
Apr 28, 2025
Merged

Customizable evaluation results filters#2232
janno42 merged 68 commits intoe-valuation:mainfrom
ybrnr:iss1786

Conversation

@jooooosef
Copy link
Collaborator

@jooooosef jooooosef commented Jun 24, 2024

fix #1786

@jooooosef jooooosef marked this pull request as draft June 24, 2024 20:49
@jooooosef jooooosef changed the title Customizable evaluation results filters #1786 Customizable evaluation results filters Jun 24, 2024
@ybrnr ybrnr force-pushed the iss1786 branch 4 times, most recently from 0127464 to ca11745 Compare July 8, 2024 15:48
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • looks good, most parts work as expected
  • tests not reviewed yet

@richardebeling richardebeling changed the title Customizable evaluation results filters Customizable evaluation results filters Oct 14, 2024
@ybrnr ybrnr force-pushed the iss1786 branch 2 times, most recently from 9bd5cea to 8aaee00 Compare October 21, 2024 16:22
@ybrnr ybrnr force-pushed the iss1786 branch 2 times, most recently from e77a156 to 73c3a65 Compare October 28, 2024 22:50
@jooooosef jooooosef marked this pull request as ready for review November 18, 2024 22:04
jooooosef and others added 4 commits March 10, 2025 21:30
right aligned the first button group and changed the order of the buttons so they align
make them one SQL query so they are faster
richardebeling
richardebeling previously approved these changes Mar 10, 2025
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for pulling through with this. I much appreciate the new tests 👍

@richardebeling richardebeling requested a review from janno42 March 10, 2025 23:13
Kakadus
Kakadus previously approved these changes Mar 17, 2025
@Kakadus Kakadus requested a review from niklasmohrin March 17, 2025 21:16
niklasmohrin
niklasmohrin previously approved these changes Mar 17, 2025
@jooooosef jooooosef dismissed stale reviews from richardebeling and janno42 via 0f06216 April 6, 2025 10:09
@jooooosef jooooosef requested a review from richardebeling April 7, 2025 20:23
richardebeling
richardebeling previously approved these changes Apr 14, 2025
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for after @janno42's comments are fixed

In light of the esteemed Cambridge Dictionary’s illumination regarding the proper orthography of visibility (https://dictionary.cambridge.org/dictionary/english/visibility), we found it necessary to amend our spelling accordingly.
@janno42 janno42 merged commit 51927c0 into e-valuation:main Apr 28, 2025
14 of 15 checks passed
@richardebeling richardebeling removed their request for review August 18, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Customizable evaluation results filters

6 participants